04097: All sets in namcos1.c: Performance regression

ID	Category [?]	Severity [?]	Reproducibility	Date Submitted	Last Update
04097	Speed	Minor	Always	Oct 24, 2010, 20:01	Jun 11, 2014, 09:19

Tester	M.A.S.H.	View Status	Public	Platform	MAME (Self-compiled)
Assigned To	AWJ	Resolution	Fixed	OS	Windows XP (32-bit)
Status [?]	Resolved			Driver	namco/namcos1.cpp
Version	0.140	Fixed in Version	0.154	Build	Normal
		Fixed in Git Commit		Github Pull Request #

Summary	04097: All sets in namcos1.c: Performance regression
Description	Since MAME 0.139u2 i got a performance regression in all Namco System 1 games. Best example is World Court (wldcourt), after the game start and pressing fast forward (Insert) i got only 70 % (340 % before) in the Namco NOTICE screen and then 650 % in the game (760 % before).
Steps To Reproduce
Additional Information
Github Commit

Flags
Regression Version	0.139u2, 0.142u3
Affected Sets / Systems	All sets in namcos1.c

Attached Files	wldcourt.png (10,568 bytes) Oct 24, 2010, 20:01

No.06800 Tafoid Administrator Oct 24, 2010, 21:50 edited on: Jul 15, 2011, 23:10	Regression was first in r9980, when all the memory changes happened. It was black screen/hang until r10032 when a number of drivers were fixed from regression testing with changes in src\emu\memory.c by Aaron: Fix logic to re-use exact-matching ranges to force a remap. Fixed almost all regressions reported. Further regression in 0.142u3 for all games in the driver - most only effected when starting up the game (low % for several seconds). Boxy Boy stays slow throughout.
No.07666 hap Developer Aug 3, 2011, 20:39	Ok, the games run ok again now. But I don't think this report should be closed until the underlying cause is fixed: machine/namcos1.c set_bank is very very very slow

No.06800

Tafoid

Administrator

Oct 24, 2010, 21:50

edited on: Jul 15, 2011, 23:10

Regression was first in r9980, when all the memory changes happened. It was black screen/hang until r10032 when a number of drivers were fixed from regression testing with changes in src\emu\memory.c by Aaron:

Fix logic to re-use exact-matching ranges to force a remap.
Fixed almost all regressions reported.

Further regression in 0.142u3 for all games in the driver - most only effected when starting up the game (low % for several seconds). Boxy Boy stays slow throughout.

No.07666

hap

Developer

Aug 3, 2011, 20:39

Ok, the games run ok again now.
But I don't think this report should be closed until the underlying cause is fixed: machine/namcos1.c set_bank is very very very slow