09104: spec128 (maybe all others, haven't tried): tap files cause crash (regression in 0.274)

ID	Category [?]	Severity [?]	Reproducibility	Date Submitted	Last Update
09104	Media Support	Critical (emulation)	Always	20 days ago	18 days ago

Tester	Robbbert	View Status	Public	Platform	MAME (Self-compiled)
Assigned To	holub	Resolution	Fixed	OS	Windows 10/11 (64-bit)
Status [?]	Resolved			Driver	sinclair/spec128.cpp
Version	0.274	Fixed in Version	0.275GIT	Build	64-bit
		Fixed in Git Commit	3dccaa6	Github Pull Request #	#13322

Summary	09104: spec128 (maybe all others, haven't tried): tap files cause crash (regression in 0.274)
Description	Since 0.274, all the .tap cassette files crash MAME at start. This includes swlist items and loose software. I've indicated this as critical because over 80% of my speccy collection is .tap files, so I am imagine it will cause inconvenience to many other users.
Steps To Reproduce	As an example: >mame spec128 astblstr The screen is black while the dump prints out.
Additional Information	C:\MAME>mame spec128 astblstr Warning: layout view 'Keyboard Layout' contains deprecated cpanel element Warning: layout view 'Keyboard Only' contains deprecated cpanel element Warning: layout view 'Keyboard Layout' contains deprecated cpanel element Warning: layout view 'Keyboard Only' contains deprecated cpanel element ----------------------------------------------------- Exception at EIP=00007ff6f9553528 (tzx_cas_handle_block(short*, unsigned char const, int, int, int, int, int, int, int, int, int)+0x0278): ACCESS VIOLATION While attempting to write memory at 000002272603b000 ----------------------------------------------------- RAX=000002272603b000 RBX=000000000002129a RCX=00000094420f8f68 RDX=00000000000003e8 RSI=0000000000000016 RDI=000000000000000b RBP=00000000ffffa562 RSP=00000094420f8ea0 R8=00000000000000e6 R9=0000000000000008 R10=00000000ffffa562 R11=0000000000000007 R12=0000000000005a9e R13=000002272438b36a R14=0000000000000000 R15=00000000000001ae ----------------------------------------------------- Stack crawl: 00000094420f8ef0: 00007ff6f9553528 (tzx_cas_handle_block(short*, unsigned char const, int, int, int, int, int, int, int, int, int)+0x0278) 00000094420f8f90: 00007ff6f95536ee (tap_cas_fill_wave(short, int, unsigned char const)+0x003e) 00000094420f9080: 00007ff6fc1b9c78 (cassette_image::legacy_construct(cassette_image::LegacyWaveFiller const)+0x01f8) 00000094420f9110: 00007ff6fc1b7cfc (cassette_image::open_choices(std::unique_ptr<util::random_read_write, std::default_delete<util::random_read_write> >&&, std::__cxx11::basic_string<char, std::char_traits<char>, std::allocator<char> > const&, cassette_image::Format const const, int, std::unique_ptr<cassette_image, std::default_delete<cassette_image> >&)+0x010c) 00000094420f9220: 00007ff6f8f21532 (cassette_image_device::internal_load(bool)+0x00c2) 00000094420f9290: 00007ff6f8f21bf5 (non-virtual thunk to cassette_image_device::call_load[abi:cxx11]()+0x0035) 00000094420f9340: 00007ff6f8f5ac8e (device_image_interface::finish_load[abi:cxx11]()+0x026e) 00000094420f9460: 00007ff6fbfb06fb (image_manager::postdevice_init()+0x017b) 00000094420f9490: 00007ff7034a4c82 (luaopen_lfs+0x27a4b92) 00000094420f95d0: 00007ff6f8c5bc18 (device_t::start()+0x0698) 00000094420f9720: 00007ff6f8dee30a (running_machine::start_all_devices()+0x014a) 00000094420f9840: 00007ff6f8df23a1 (running_machine::start()+0x0a91) 00000094420f99c0: 00007ff6f8df594c (running_machine::run(bool)+0x00cc) 00000094420fefe0: 00007ff6fbf8203c (mame_machine_manager::execute()+0x024c) 00000094420ff3d0: 00007ff6ffcc694a (cli_frontend::start_execution(mame_machine_manager, std::vector<std::__cxx11::basic_string<char, std::char_traits<char>, std::allocator<char> >, std::allocator<std::__cxx11::basic_string<char, std::char_traits<char>, std::allocator<char> > > > const&)+0x03ea) 00000094420ff6e0: 00007ff6ffcc6f7a (cli_frontend::execute(std::vector<std::__cxx11::basic_string<char, std::char_traits<char>, std::allocator<char> >, std::allocator<std::__cxx11::basic_string<char, std::char_traits<char>, std::allocator<char> > > >&)+0x007a) 00000094420ff740: 00007ff6fbf7cde7 (emulator_info::start_frontend(emu_options&, osd_interface&, std::vector<std::__cxx11::basic_string<char, std::char_traits<char>, std::allocator<char> >, std::allocator<std::__cxx11::basic_string<char, std::char_traits<char>, std::allocator<char> > > >&)+0x0027) 00000094420ffb10: 00007ff701965ac1 (luaopen_lfs+0xc659d1) 00000094420ffb60: 00007ff6f50412ee (__tmainCRTStartup+0x016e) 00000094420ffb90: 00007ff6f5041406 (mainCRTStartup+0x0016) 00000094420ffbc0: 00007ffb59397374 (BaseThreadInitThunk+0x0014) 00000094420ffc40: 00007ffb5967cc91 (RtlUserThreadStart+0x0021)
Github Commit

Flags
Regression Version	0.274
Affected Sets / Systems	spec128 (maybe all others, haven't tried)

Attached Files