08939: jupace: Cassette recording records from speaker instead of MIC output

ID	Category [?]	Severity [?]	Reproducibility	Date Submitted	Last Update
08939	Core	Minor	Always	30 days ago	29 days ago

Tester	pgimeno	View Status	Public	Platform	MAME (Unofficial Binary)
Assigned To	pgimeno	Resolution	Fixed	OS	Linux (64-bit)
Status [?]	Resolved			Driver	cantab/jupace.cpp
Version	0.251	Fixed in Version	0.271	Build	64-bit
		Fixed in Git Commit	741cbdd	Github Pull Request #

Summary	08939: jupace: Cassette recording records from speaker instead of MIC output
Description	When trying to save a program to cassette using -cass xxxx.wav, what gets recorded to the wav file is not the MIC output but the sound (speaker) output. This results in a weird sound that doesn't correspond to what a real Jupiter saves to cassette, but to what it outputs via speaker, which is different. As a result, the generated .wav is useless.
Steps To Reproduce	1. Invoke MAME like this: mame jupace -cass example.wav 2. Type for example the following: 0 200 bsave x 3. Open the UI, go to Tape Control and select Record. 4. Press Enter on the Jupiter. 5. Go to Tape Control and select Pause/Stop. 6. Close MAME and check the resulting wav file. The wav file won't contain anything remotely similar to the Jupiter tape format (which sounds pretty much like the Spectrum's), but a strange sound which is also emitted while saving. This would be correct if saving the sound output of the Jupiter (like what you do with -wavwrite), but the cassette output should contain the output of the MIC line (bit 3 of I/O port 0xFE) instead of the output of the speaker line.
Additional Information
Github Commit

Flags
Regression Version
Affected Sets / Systems	jupace

Attached Files

No.22381 hap Developer 29 days ago	Fixed here: https://github.com/mamedev/mame/commit/741cbdd2a3af4a4e96819a354f93b861a669991c I saved a cass, tested with bload, and that works ok. I also did some cleanups. FYI I usually assign MT bug fix credit to the reporter when the exact cause of the bug was included and it's simple to fix.