08915: Any system that quickloads COM files: Incorrect error message

ID	Category [?]	Severity [?]	Reproducibility	Date Submitted	Last Update
08915	Media Support	Minor	Always	Sep 11, 2024, 15:24	Sep 18, 2024, 10:31

Tester	Robbbert	View Status	Public	Platform	MAME (Self-compiled)
Assigned To	Robbbert	Resolution	Fixed	OS	Windows 10/11 (64-bit)
Status [?]	Resolved			Driver
Version	0.269	Fixed in Version	0.270	Build	64-bit
		Fixed in Git Commit	9a593dd	Github Pull Request #

Summary	08915: Any system that quickloads COM files: Incorrect error message
Description	If a COM or CPM file is loaded in a system that supports it, a meaningless error appears on the console, and an invalid popup momentarily appears.
Steps To Reproduce	You must choose any supporting CP/M system, such as aussieby, and use a COM file as input. The error will appear because CPM needs to have been booted before the quickload is loaded. Example: >mame aussieby -quik e:\data\cpm\aussieby\aussie-byte\fx.com (you need to substitute the system and software you have on hand) Firstly it says: :quickload: Error loading 'fx.com' : Unsupported operation (image:2) then the popup says Error loading 'fx.com' : %4$s As you can see, the first message provides no useful info to the user - they would never guess that CP/M needs to be running first. The popup is clearly missing a parameter.
Additional Information	The following systems use a similar quickload feature and should be checked for the above issue. altos5, aussieby, bigboard, dmv, kaypro & clones, mk82, mk83, mojmikro, qx10, smc777, x168, x820, x820ii.
Github Commit

Flags
Regression Version
Affected Sets / Systems	Any system that quickloads COM files

Attached Files

No.22321 hap Developer Sep 12, 2024, 13:32	"Error loading 'fx.com' : %4$s" was fixed. Or was the main purpose for this bug report that the error message is meaningless? You're the driver author, so just change it to what you want? return std::make_pair(image_error::UNSUPPORTED, std::string()); -> return std::make_pair(image_error::UNSUPPORTED, "I have a hole in my sock");
No.22322 Robbbert Senior Tester Sep 12, 2024, 23:28	There's nothing I can do to correct Mame, so this report was raised so that someone with the rights can fix it. I suppose I can update my build, and leave Mame as is. Thanks for showing me how to add the extra text.
No.22324 hap Developer Sep 13, 2024, 07:55	Ok I'll reopen the bug report. If you're going to update the error messages in your drivers but don't want to do a pull request, just send the modified files to someone?
No.22325 Robbbert Senior Tester Sep 13, 2024, 08:06	I don't do PRs, I've seen what happens. When I'm ready I'll contact you.