08582: c128 all variations: No Data is read from the tape drive simulation.

ID	Category [?]	Severity [?]	Reproducibility	Date Submitted	Last Update
08582	Media Support	Major	Always	Mar 17, 2023, 22:04	Mar 29, 2023, 13:20

Tester	Walker	View Status	Public	Platform	MAME (Official Binary)
Assigned To	curtcoder	Resolution	Fixed	OS
Status [?]	Resolved			Driver	commodore/c128.cpp
Version	0.251	Fixed in Version	0.253	Build
		Fixed in Git Commit	2a6879c	Github Pull Request #

Summary	08582: c128 all variations: No Data is read from the tape drive simulation.
Description	All tapes from the c64 software list (which are working on the c64 device) are not working on the c128 devices at all. I also tried to read the file directory from the tapes, but no data is being received at all.
Steps To Reproduce	Insert any tape fom the c64 software list and try to start it.
Additional Information	At first I thought that maybe some garbled data arrives, but testing it shows that no data at all is being received by the emulated machine. Generally all c64 tape games ran on the c128.
Github Commit

Flags
Regression Version
Affected Sets / Systems	c128 all variations

Attached Files

No.21179 Walker Tester Mar 18, 2023, 11:25 edited on: Mar 19, 2023, 13:42	tested down to MAME 0.236 seems tape never worked in c128? Problem is also in MAME 0.252
No.21181 Robbbert Moderator Mar 19, 2023, 15:46 edited on: Mar 19, 2023, 15:53	According to my spreadsheet of cassette testing: c128: "Doesn't load. Save verified on c64." Which means: The c128 can save a valid cassette image, which can be loaded onto the c64. The c128 is unable to load any cassette, even ones it made. Therefore, I'm able to confirm this report without having to test it again. At this stage, I would assume it never worked.
No.21204 Robbbert Moderator Mar 24, 2023, 14:27	Seems this might be fixed by 2a6879c6a4692726ecae641aa9652453fd64bd28 - to be confirmed.
No.21213 Walker Tester Mar 25, 2023, 21:36	It looks like commit https://github.com/mamedev/mame/commit/2a6879c6a4692726ecae641aa9652453fd64bd28 really solves this bug. I just tested it with nebulus from the softlist and could successfully load the tape file and start the game. Great Work, thank you curt_coder!
No.21215 Robbbert Moderator Mar 25, 2023, 23:38	Thanks for testing. It appears that Curt Coder is not registered here, so I've left the "Assigned to" field blank.
No.21224 curtcoder Developer Mar 29, 2023, 13:20	I am now :)