08265: spectrum and clones [aquaplan and clones]: Horizon line broken by the screen border

ID	Category [?]	Severity [?]	Reproducibility	Date Submitted	Last Update
08265	Graphics	Minor	Always	Mar 21, 2022, 14:30	Jun 20, 2022, 21:04

Tester	ICEknight	View Status	Public	Platform	MAME (Official Binary)
Assigned To	holub	Resolution	Fixed	OS	Windows 10/11 (64-bit)
Status [?]	Resolved			Driver	sinclair/spectrum.cpp
Version	0.241	Fixed in Version	0.245	Build	64-bit
		Fixed in Git Commit		Github Pull Request #	#9945

Summary	08265: spectrum and clones [aquaplan and clones]: Horizon line broken by the screen border
Description	The horizon line is shifted upwards in the screen borders, while real hardware tests show that the transition should be more seamless. Spectrum 48K tests: https://photos.google.com/share/AF1QipNG4DqWvSIieYPol7_WN9vnHn6udJcPgkGcpepl_tBlr1rwzVU2JghLHxorKGE5MQ?key=OENvckF4OU5FRXlKRExuT0Y1bzJkcF8yckZGWFJn Spectrum 128K +2 tests: https://photos.google.com/share/AF1QipPiXgBk4pyyJIUtEso9Q6i6B4OLu_WiiQwgTJOslqGlBo1huARRe31NSPzCSK7lqQ?key=X2xKU1RHazJOd1V4UFlCNmtPbTIxYTY5MmdNcmZB
Steps To Reproduce	Just load the game with LOAD"": -Press J for "LOAD" -Press Shift+P twice -Press enter, then F2 to start the cassette (with UI controls enabled) -Wait until the game loads
Additional Information
Github Commit

Flags	Verified with Original
Regression Version
Affected Sets / Systems	spectrum and clones [aquaplan and clones]

Attached Files	0000.png (3,312 bytes) Mar 21, 2022, 14:30 Uploaded by ICEknight MAME 0.241/2022.03 spectrum
	aquaplane 48k.jpg (11,518 bytes) Mar 21, 2022, 14:31 Uploaded by ICEknight Real hardware, Spectrum 48K
	aquaplan.png (3,053 bytes) Mar 21, 2022, 14:36 Uploaded by ICEknight MAME 0.241/2022.03 specpls2
	aquaplane128k1.jpg (24,704 bytes) Mar 21, 2022, 14:37 Uploaded by ICEknight Real hardware, Spectrum 128K +2
	20220511_040230.jpg (659,917 bytes) May 11, 2022, 22:35 Uploaded by ICEknight Real hardware, Spectrum 128K +2 (left border)
	20220511_040128.jpg (191,498 bytes) May 11, 2022, 22:35 Uploaded by ICEknight Real hardware, Spectrum 128K +2 (right border)

No.20165 ICEknight Tester May 4, 2022, 22:41 edited on: May 4, 2022, 23:11	This looks much better now with holub's changes, though we'd need to have better up-close pictures of 48K, 128K and +2B/+3 models to see if the level differences between horizon line and border which are seen in emulation really match real hardware. https://github.com/mamedev/mame/pull/9670
No.20178 ICEknight Tester May 11, 2022, 22:45 edited on: May 11, 2022, 22:47	Added close pictures of the left and right borders on a real Spectrum +2, showing that they should be off by one and two pixels respectively. With the current changes, MAME shows both being off by 2.
No.20327 holub Tester Jun 17, 2022, 23:58	That's going to be potential fix if accepted: https://github.com/mamedev/mame/pull/9945
No.20334 ICEknight Tester Jun 20, 2022, 20:04	Fixed with holub's PR.