07569: avspa: png for avspa crashes mame

ID	Category [?]	Severity [?]	Reproducibility	Date Submitted	Last Update
07569	Media Support	Minor	Always	Feb 19, 2020, 21:40	Feb 20, 2020, 10:38

Tester	RomKnight	View Status	Public	Platform	MAME (Official Binary)
Assigned To		Resolution	No change required	OS	Windows 10 (64-bit)
Status [?]	Closed			Driver	capcom/cps2.cpp
Version	0.218	Fixed in Version		Build	64-bit
		Fixed in Git Commit		Github Pull Request #

Summary	07569: avspa: png for avspa crashes mame
Description	the available file (attached) crashes mame. The file I have matches crc32 and sha1 hash of the original file: CRC32: E186C782 SHA1: 0B2C43E7367064CA7B526B067C8F76ED11EC3A40 As far as I know, it's been around for a decade and it opens in other software. Others say the same, AntoPISA can't seem to repro this with version .218 I've tested 64bit versions from .171 (first where mame ui shows snapshots) and until .188 the same file works. On version .189 to .193 mame crashes and i did not test more except .215 to .218 where obviously still happens. In mame .189 one can read: -PNG/rendering/artwork/output improvements: [Vas Crabb] (several points follow), please refer to .189 release notes Mame crashes with the error: "avspa.png: Error reading PNG file" In order to open mame again, I have to edit ui.ini and clear the line "last_used_machine"
Steps To Reproduce	use the attached file as artwork search for avspa (or scroll over it)
Additional Information
Github Commit

Flags
Regression Version	.189
Affected Sets / Systems	avspa

Attached Files	avspa.png (32,280 bytes) Feb 19, 2020, 21:48 Uploaded by RomKnight

No.17410 Tafoid Administrator Feb 19, 2020, 21:50 edited on: Feb 19, 2020, 21:52	I've attached what the current PNG for snapshots show that is available from progettosnaps file: https://mega.nz/#!WJQD0QTC!HjdA9xBJvPgkxBQVnHraHEhMfYAcDuj__llfmhWb63I - pS_snap_fullset_218 .zip Inside the snap/7z file, there is an avspa.png file with the following stats: Name: avspa.png Size: 32280 CRC32: 7e00a75d MD5: 92311befaa5d0090bc924286da89bef3 SHA1: c4a9a881fadfd8ed6b254af9691da0cf13d6b1fb While when I attempt to view the file while in the user interface I do not get a crash, I do get a message printed to console as you mentioned: avspa.png: Error reading PNG file Looking through Windows Photo Viewer, it shows quite plainly that it appears to have corrupt data, with a lot of color differences and oddness.
No.17411 RomKnight Tester Feb 19, 2020, 22:01	And you are right. I think that file should be replaced and it started happening in .189 precisely because of this (in .189 release notes): *Detect more invalid PNG files rather than just behaving badly.
No.17412 Robbbert Senior Tester Feb 19, 2020, 23:13	Tested the attached file: Firefox - blank screen Office 2010 picture viewer - shows with corruptions Windows Photo Viewer - shows with corruptions MAME - nothing, but get console message MAMEUI - crashed. Antopisa's files are not official - just make a new snapshot for yourself - let the game run to where you want, then hit F12.
No.17413 RomKnight Tester Feb 20, 2020, 00:24	Noted. File will probably be replaced by next .219 version, by the way. Guess we can close this one although, maybe there's a way to avoid the crash and handle such things gracefully? I mean, even if I take a screenshot myself, it can get corrupted for some reason down the line. Wouldn't be a first in ntfs by only copying to another drive! Thanks for the prompt support.
No.17414 Tafoid Administrator Feb 20, 2020, 00:49 edited on: Feb 20, 2020, 00:50	RomKnight: As far as crashing, not sure what to say. It sure sounds like (as verified by Robbbert) you are using MAMEUI and not the official binary as that is the only form in which the entire emulator is crashing when hitting that corrupt "avspa.png" file. It doesn't happen with MAMEDEV.org produced binaries.
No.17415 Robbbert Senior Tester Feb 20, 2020, 10:37	RomKnight, please note that Mametesters bugs must be made against official MAME. Derivative builds such as MAMEUI are unofficial. I'm going to close this now, since there's nothing wrong with MAME.