07482: apple2, apple2e and clones: Graphics colors not matching original machines

ID	Category [?]	Severity [?]	Reproducibility	Date Submitted	Last Update
07482	Color/Palette	Minor	Always	Nov 12, 2019, 09:20	Dec 9, 2019, 15:00

Tester	xolson	View Status	Public	Platform	MAME (Official Binary)
Assigned To	R. Belmont	Resolution	Fixed	OS	Windows Vista/7/8 (64-bit)
Status [?]	Resolved			Driver	apple/apple2.cpp
Version	0.215	Fixed in Version	0.217	Build	64-bit
		Fixed in Git Commit		Github Pull Request #

Summary	07482: apple2, apple2e and clones: Graphics colors not matching original machines
Description	The graphics colors on the mame apple2 series are not matching the original machines colors. The file A2Ee.COLOR.DEMOSOFT.png shows a screenshot of the mame output of the COLOR DEMOSOFT program. Magenta is too light/red, Dark Blue looks like lavender, purple looks pink, Dark Green is not dark, medium blue is light, light blue is grey, brown is greenish. The file Apple_II_low-resolution_graphics_demo_2.png shows what the colors should look like.
Steps To Reproduce	Load DOS 3.3 System Master, RUN COLOR DEMOSOFT
Additional Information	I have tested this on the apple2, apple2p, apple2e, and apple2ee they all give this same result.
Github Commit

Flags
Regression Version
Affected Sets / Systems	apple2, apple2e and clones

Attached Files	A2Ee.COLOR.DEMOSOFT.png (29,017 bytes) Nov 12, 2019, 09:20 Uploaded by xolson mame color bar screenshot
Attached Files	Apple_II_low-resolution_graphics_demo_2.png (6,865 bytes) Nov 12, 2019, 09:21 Uploaded by xolson apple2 colors should be these

No.17258 R. Belmont Developer Dec 9, 2019, 04:15	I have updated the palette to the latest mathematical model from Apple II Video Display Theory at https://docs.google.com/spreadsheets/d/1rKR6A_bVniSCtIP_rrv8QLWJdj4h6jEU1jJj0AebWwg/edit This revised palette seems to fix your complaints about the colors: magenta is darker, dark blue is more blue, purple is more purple, dark green is darker, medium blue is darker, etc, etc.
No.17259 xolson Tester Dec 9, 2019, 06:48	Yay! Thanks, that will help when displaying double hires pictures.
No.17260 xolson Tester Dec 9, 2019, 10:37	Looking at the web spreadsheet you linked to the only color I disagree with on it is "light blue" that looks like lilac to me. On actual hardware light blue is indeed somewhat close to that but it still seems bluer.
No.17261 R. Belmont Developer Dec 9, 2019, 15:00	Matching real hardware on the A2 is rough because different monitors will display slightly different colors, and that's before you include color and tint controls and so on. That spreadsheet assumes an idealized NTSC monitor, which probably doesn't exist (a Sony BVM might be close). The end goal is that we'll output a digital representation of the video signal and a shader chain on the GPU will apply the NTSC processing with all the knobs available, but for now this does definitely improve the color on all the software I tried.