07329: specpls2, specpl2a, specpls3: Inputs (this Machine) ignores Inputs (general)

ID	Category [?]	Severity [?]	Reproducibility	Date Submitted	Last Update
07329	DIP/Input	Minor	Always	May 10, 2019, 21:42	Nov 30, 2019, 23:52

Tester	ICEknight	View Status	Public	Platform	MAME (Official Binary)
Assigned To		Resolution	Open	OS	Windows 10 (64-bit)
Status [?]	Confirmed			Driver	sinclair/specpls3.cpp
Version	0.209	Fixed in Version		Build	64-bit
		Fixed in Git Commit		Github Pull Request #

Summary	07329: specpls2, specpl2a, specpls3: Inputs (this Machine) ignores Inputs (general)
Description	For the Spectrum models which have two integrated joystick ports, their default controls are not taken from "Inputs (General)".
Steps To Reproduce	Just have anything other than the default controls set in "Input (general)" and open "Input (this Machine)".
Additional Information	Any additional devices (attached Kempston or Fuller joysticks) are correctly assigned to Player 3 and work fine.
Github Commit

Flags
Regression Version
Affected Sets / Systems	specpls2, specpl2a, specpls3

Attached Files	mame spectrum keys 2.png (240,882 bytes) May 10, 2019, 21:42 Uploaded by ICEknight Input (this Machine)
Attached Files	mame spectrum keys 1.png (294,916 bytes) May 10, 2019, 21:43 Uploaded by ICEknight Inputs (general)

No.16451 Tafoid Administrator May 10, 2019, 23:15	Not quite sure why it is malfunctioning. Many joysticks are set up as devices and are properly transferred in cases of global remapping. Perhaps these controls are added in some unique way? I've tried a few different computers/consoles/arcades and adam, cdkong, defender, mrdo, zookeep look ok on my end. I saw atari400.cpp machines were not carrying over mapping as well. Where is the common factor?
No.16456 Osso Moderator May 11, 2019, 08:14	Nice intuition, Tafoid. The common factor is they use PORT_CODE() and it seems that stops "Input (this Machine)" from automatically inherit from "Inputs (General)". This is probably expected behaviour, though I'm not sure.
No.16459 ICEknight Tester May 13, 2019, 20:40 edited on: May 13, 2019, 20:41	I can't think of a reason for deliberately not getting the controls for the first two players from the General settings, maybe it's just a really old implementation from the old MESS days?
No.17232 r0ast3r Tester Nov 30, 2019, 23:52	Well I recently added joystick ports to samcoupe driver, the PR wasn't accepted until I removed the PORT_CODE stuff for this same issue, see here: https://github.com/mamedev/mame/pull/5947