07104: bbh, bbhsc, bbhsca, bbh2sp, bbh2spa, bbh2spb: Targeting is off

ID	Category [?]	Severity [?]	Reproducibility	Date Submitted	Last Update
07104	DIP/Input	Minor	Always	Sep 22, 2018, 15:47	Mar 2, 2019, 00:14

Tester	mmarino4	View Status	Public	Platform	MAME (Official Binary)
Assigned To	Osso	Resolution	Fixed	OS	Windows 10 (64-bit)
Status [?]	Resolved			Driver	itech/iteagle.cpp
Version	0.201	Fixed in Version	0.206	Build	64-bit
		Fixed in Git Commit		Github Pull Request #

Summary	07104: bbh, bbhsc, bbhsca, bbh2sp, bbh2spa, bbh2spb: Targeting is off
Description	After calibrating the gun, the crosshair does not match where the game thinks you are aiming. It worked correctly in 0.199 but 0.200 and 0.201 have this issue. Call of the Wild and Carnival King do not have this problem as the calibration setup is done with multiple points.
Steps To Reproduce	Start the game and go into the test menu. Select Gun Calibration and shoot the target in the center. The next screen will show where the game thinks you are aiming which does not match the crosshair, particularly as you travel away from the center of the screen. This also occurs during regular gameplay.
Additional Information
Github Commit

Flags
Regression Version	0.200
Affected Sets / Systems	bbh, bbhsc, bbhsca, bbh2sp, bbh2spa, bbh2spb

Attached Files

No.15484 Tafoid Administrator Sep 22, 2018, 17:32	This commit is likely culprit: https://github.com/mamedev/mame/commit/e0912401ae4073f379e482df33d00a0648a0e74b Confirmed using bbh
No.15485 mmarino4 Tester Sep 22, 2018, 20:05	I tried the alternate versions bbh2spa, bbh2spb and bbhsca and they all had issues even on 0.199. In some cases the input is not accepted at all.
No.16048 Osso Moderator Jan 18, 2019, 20:45	FWIW changing line 280 of iteagle_fpga.cpp from result = (m_guny_cb(0) << 16) \| (m_gunx_cb(0) << 0); to result = (m_gun_y << 16) \| (m_gun_x << 0); seems to fix this (tested with bbh), but since Ted seems to have changed it on purpose I won't apply this.
No.16050 tedgreen Developer Jan 19, 2019, 17:32	Yeah that change definitely wasn't intended. Thanks a lot for looking into this. The fix is pushed. https://github.com/mamedev/mame/commit/247eb1fa77f86d8991acb04be8106aa54a979e7e
No.16200 mmarino4 Tester Mar 2, 2019, 00:14	The parents sets are good now but it's probably worth leaving this open for the clone sets. bbhsca - no valid input on low res, black screen on medium res bbh2spa - targeting is off on low res, ok on medium bbh2spb - targeting off on both resolutions (though it appears low res switches to medium anyway)