07071: docastle, docastle2: "Advance Level on Getting Diamond" DIP setting inverted.

ID	Category [?]	Severity [?]	Reproducibility	Date Submitted	Last Update
07071	DIP/Input	Minor	Always	Aug 7, 2018, 10:40	3 days ago

Tester	ozfalcon	View Status	Public	Platform	SDLMAME
Assigned To	ozfalcon	Resolution	Fixed	OS	Linux (64-bit)
Status [?]	Resolved			Driver	universal/docastle.cpp
Version	0.200	Fixed in Version	0.272GIT	Build	64-bit
		Fixed in Git Commit	e659dfa	Github Pull Request #

Summary	07071: docastle, docastle2: "Advance Level on Getting Diamond" DIP setting inverted.
Description	"Advance Level on Getting Diamond" DIP setting inverted. When set to OFF then level IS advanced upon collecting diamond. When set to ON then level is not advanced upon collecting diamond. While the dip position is technically correct, the function is inverted. DIP ON = Advance Level Disabled DIP OFF = Advance Level Enabled This makes the description unintuitive and appear opposite to it's intention. As DIP Settings in Mame are representing the actual dip switches eg. Lives = 3 Likewise "Advance Level on Getting Diamond" should be represented by "Enabled/Disabled" rather than the On/Off switch setting.
Steps To Reproduce	Set "Advance Level on Getting Diamond" DIP to OFF and play game until a diamond is presented / collected. With the setting OFF, When a diamond is collected the game will display Congratulations & advance Credit & Level.
Additional Information	Original (docastleo) set does not have this feature, Only sets 1 & 2 (docastle, docastle2). https://www.arcade-museum.com/game_detail.php?game_id=8771 https://github.com/mamedev/mame/blob/master/src/mame/drivers/docastle.cpp#L365 I'm not sure where the reference "Advance Level on Getting Diamond" came from, Though it Advances both Credit & Level (With a Congratulations screen) when activated. Unless the DIP was specifically labeled then a better description might be: "Advance Credit & Level on Diamond"
Github Commit

Flags
Regression Version
Affected Sets / Systems	docastle, docastle2

Attached Files	DoCastleDIP.png (87,834 bytes) Aug 7, 2018, 10:40 Uploaded by ozfalcon

No.15315 Tafoid Administrator Aug 7, 2018, 15:26	Be specific with MAME's setname when reporting differences between sets, especially. Adjusted bug to match reporting standards
No.15333 B2K24 Senior Tester Aug 13, 2018, 04:56	I haven't seen a diamond appear as of yet. Still trying to work on it when time permits.
No.22447 hap Developer 3 days ago	I couldn't get a diamond at all, but I'll take your word for it. It makes more sense too, that DSW OFF (the default for all dipswitches in docastle) gets you the default setting for extra credit + next level.