07016: astrowar: game resets at start of stage 5

ID	Category [?]	Severity [?]	Reproducibility	Date Submitted	Last Update
07016	Crash/Freeze	Critical (emulation)	Always	Jun 12, 2018, 16:06	Aug 22, 2018, 05:56

Tester	Kale	View Status	Public	Platform	MAME (Self-compiled)
Assigned To		Resolution	Open	OS	Windows Vista/7/8 (64-bit)
Status [?]	Confirmed			Driver	cvs/galaxia.cpp
Version	0.198	Fixed in Version		Build	64-bit
		Fixed in Git Commit		Github Pull Request #

Summary	07016: astrowar: game resets at start of stage 5
Description	Astro Wars resets itself at start of stage 5, right after drawing the background vertical lines and before showing the boss.
Steps To Reproduce	Reach stage 5 or load attached save state (need to kill stage 4 last enemy). Preferably load it after the POST, save states aren't offcially supported by the game.
Additional Information	Culprit seems to be this snippet: 1:09F9: loda,0 $35ad ;reads s2636 port 1:09FC: comi,0 $80 1:09FE: bctr,p $2a14 1:0A00: bdrr,3 *$29fa 0:15AD: loda,0 $0000 ;jumps to s2636 area? Could be either s2650 or s2636 core bug. Seldomly this doesn't occur, by hitting the last enemy in specific spots? Seems to happen up to version 0.169
Github Commit

Flags
Regression Version
Affected Sets / Systems	astrowar

Attached Files	r.zip (1,191 bytes) Jun 12, 2018, 16:06 Uploaded by Kale
Attached Files	0017.png (1,978 bytes) Jun 12, 2018, 16:08 Uploaded by Kale Snapshot of the game prior to reset.

No.15169 kazblox Tester Jun 12, 2018, 20:22	This driver is poor already (among the many things is that video needs a total rewrite to support the actual RAW_PARAMS configuration which is similar to Lazarian), but this does look like a core bug at a glance. Nice catch.
No.15179 AJR Developer Jun 15, 2018, 15:46	I suspect that this might actually be a bad dump. In context, it seems as if the BDRR,3 opcode (FB) ought to be COMR,3 (EB) instead.
No.15337 AJR Developer Aug 21, 2018, 18:55	I've decided to mark one ROM as a bad dump for now, in the hope that it can be redumped and verified. There isn't another dumped set for code comparison purposes, the code performs no self-test (contrary to the "POST" mention in the report), and, given how stupidly difficult the game is to play, I fear it might have actually shipped with this bug.
No.15338 Osso Moderator Aug 22, 2018, 05:56	FWIW I've asked an Italian owner for a redump, he agreed but it won't be in the near future, as he doesn't have access to his games right now.