06857: 34010 & 34020: Cheats not working in btoads and other games.

ID	Category [?]	Severity [?]	Reproducibility	Date Submitted	Last Update
06857	Cheat System	Major	Always	Jan 28, 2018, 00:45	Jan 28, 2018, 17:04

Tester	austinwolfclaw	View Status	Public	Platform	MAME (Official Binary)
Assigned To	galibert	Resolution	Fixed	OS	Windows 10 (64-bit)
Status [?]	Resolved			Driver	rare/btoads.cpp
Version	0.193	Fixed in Version	0.194	Build	64-bit
		Fixed in Git Commit		Github Pull Request #

Summary	06857: 34010 & 34020: Cheats not working in btoads and other games.
Description	i talked to pugsy about this and he replied "The addresses for btoads need to multiplied by 8. This has affected other games as well that use the 34010 & 34020 like various mk games and narc However, it doesn't seem to be have done correctly/completely as regards cheats. I think it was changed to address the odd memory system for those games.. As an example NARC was fine as regards the memory system and the debugger expressions (used for cheats) "wp 100B7E0,1,w" would work fine (lives poke) and you could see the value in the memory window for 100B7E0 and you could change it by typing maincpu.pb@100B7E0=6 so all was good but now you have to change the memory with maincpu.pb@(100B7E0*8)=6 or maincpu.pb@805BF00=6 I will hold fire before changing anything in the cheat collection as it will be a LOT of work, and I haven't any time at the moment especially for something that may change again..." The cheats worked in .191 and i skipped 192 cuz i was behind, i'm at 193 and no cheats for this game are working.
Steps To Reproduce	launch game go into cheat menu enable infinite lives and infinite energy no result.
Additional Information	I'm not a hundred percent sure of what changed between 191 and 193 in terms of this game and apparently others that use 34010 & 34020, whatever that means.
Github Commit

Flags
Regression Version
Affected Sets / Systems	34010 & 34020

Attached Files

No.14687 B2K24 Senior Tester Jan 28, 2018, 07:04	Is this an actual MAME bug/regression of some kind or is it a case of cheat files needing to be changed/updated to reflect MAME changes?
No.14688 NekoEd Senior Tester Jan 28, 2018, 09:25 edited on: Jan 28, 2018, 09:37	[04:31:21] <cuavas> commit c46e1007a8c0b42b7c50dce9b8bc9dff0db328e5 https://github.com/mamedev/mame/commit/c46e1007a8c0b42b7c50dce9b8bc9dff0db328e5 An explanation of what changed is included in the commit message. If anyone has an account on the cheat forums, let Pugsy know. I'm going to close this now since it's not our bug.
No.14689 cuavas Administrator Jan 28, 2018, 13:57	Turns out there were still some stray address-to-byte calls that OG missed.
No.14690 galibert Developer Jan 28, 2018, 17:04	e8795aaf597e7e985234cefebddc8e79626c96b9 should fix the expression from debugger one, and ba9b1aac0932ac490176492befc7928322e3553e should fix memory accesses from lua scripts. Hopefully cheats work again :-)