05997: a500, a500p, a1000, a1200, a2000, a3000, a4000, a4000t, a600, cd32 and clones (all): ADF read crash

ID	Category [?]	Severity [?]	Reproducibility	Date Submitted	Last Update
05997	Crash/Freeze	Major	Always	Jul 24, 2015, 21:32	Jul 29, 2015, 19:02

Tester	kazblox	View Status	Public	Platform	MESS (Official Binary)
Assigned To	galibert	Resolution	Fixed	OS	Windows Vista/7/8 (64-bit)
Status [?]	Resolved			Driver	amiga/amiga.cpp
Version	0.163	Fixed in Version	0.164	Build	Normal
		Fixed in Git Commit		Github Pull Request #

Summary	05997: a500, a500p, a1000, a1200, a2000, a3000, a4000, a4000t, a600, cd32 and clones (all): ADF read crash
Description	Simply loading all adf files from/not from a software list causes read errors from track 0, crashes MAME, and returns this message: "FATALERROR: Incorrect MG information in generate_track_from_levels, track 0 head 0"
Steps To Reproduce	1. Load an adf file into floppy device in any of the sets 2. Crash.
Additional Information	Used to work, so there must be a regression.
Github Commit

Flags
Regression Version	0.161
Affected Sets / Systems	a500, a500p, a1000, a1200, a2000, a3000, a4000, a4000t, a600, cd32 and clones (all)

Attached Files

No.11894 Tafoid Administrator Jul 24, 2015, 22:17	Confirmed using "mame a500p -flop1 wbenc12.zip" - copy from softlist Regression traced to between April 12 to April 14. Specific suspect is here: https://github.com/mamedev/mame/commit/278cf84e5503d1829e837e21dc8c238bc8cab577 Replace dynamic_array with std::vector [O. Galibert]
No.11906 kazblox Tester Jul 29, 2015, 11:52	Confirmed fixed as of 0.164 with https://github.com/mamedev/mame/commit/af55f61abfac5e03dd1c8a060953ee63ca2b9a87