04267: -verifyroms list nonexistent roms as bad

ID	Category [?]	Severity [?]	Reproducibility	Date Submitted	Last Update
04267	Interface	Minor	Always	Mar 1, 2011, 20:17	Apr 3, 2011, 08:34

Tester	belegdol	View Status	Public	Platform	SDLMAME
Assigned To	aaron	Resolution	Fixed	OS
Status [?]	Resolved			Driver
Version	0.141u3	Fixed in Version	0.141u4	Build
		Fixed in Git Commit		Github Pull Request #

Summary	04267: -verifyroms list nonexistent roms as bad
Description	This is similar to issue 444, but I guess I should open a new one since the old one is marked as fixed. As before, quite a lot of sys573 roms light up as bad, even though I don't have them in my rompath, only the bios. Similar thing started to happen with with goldnaxe clones. $ mame -verifyroms sys573 romset sys573 is good 1 romsets found, 1 were OK. $ mame -verifyroms gtfrk3ma gtfrk3ma: 949jaa.u1 (548 bytes) - NOT FOUND (shared with parent) gtfrk3ma: ge949jab.u1 (4116 bytes) - NOT FOUND (shared with parent) gtfrk3ma: 949jaa.u6 (8 bytes) - NOT FOUND (shared with parent) gtfrk3ma: ge949jab.u6 (8 bytes) - NOT FOUND (shared with parent) gtfrk3ma: 949jab02 - NOT FOUND romset gtfrk3ma [gtrfrk3m] is bad 1 romsets found, 0 were OK. $ mame -verifyroms goldnaxe goldnaxe: 317-0123a.bin (4096 bytes) - NOT FOUND - NO GOOD DUMP KNOWN romset goldnaxe is best available 1 romsets found, 1 were OK. $ mame -verifyroms goldnaxe1 goldnaxe1: epr-12389.ic2 (262144 bytes) - NOT FOUND (shared with parent) goldnaxe1: epr-12388.ic1 (262144 bytes) - NOT FOUND (shared with parent) goldnaxe1: 317-0110.key (8192 bytes) - NOT FOUND (shared with parent) romset goldnaxe1 [goldnaxe] is bad 1 romsets found, 0 were OK.
Steps To Reproduce	1) put non-merged goldnaxe.zip in the roms folder. 2) take out any clone sets of goldnaxe from the roms folder 3) -verifyroms "any of clone sets"
Additional Information
Github Commit

Flags
Regression Version	0.141u3
Affected Sets / Systems

Attached Files

No.07279 Tafoid Administrator Mar 2, 2011, 04:13	Are your romsets fully merged (all roms in parent), split merged (each set has unique roms) or fully unmerged (all roms that a set needs is in the zip, even if shared by parent)? There have been assorted reports of -verifyroms oddness, but nothing concrete as to a surefire way to trigger it.
No.07280 Fujix Administrator Mar 2, 2011, 11:59 edited on: Mar 2, 2011, 16:32	I didn't manage to let -verifyroms to output "(shared with parent)" in any combination (marging goldnaxe1 with goldnaxe, putting goldnaxe1 and marged goldnaxe, copied and renamed the merged goldnaxe as goldnaxe1). If I remove any files of goldnaxe1 and do -verifyroms, MAME suggested approximate game name matches instead reporting ROM check result. I guess you might have goldnaxe1 ROMs somewhere else?? Anyway, we need your ROM compositions to confirm the issue.
No.07281 Nightvoice Tester Mar 2, 2011, 16:46	In my case, I don't even use clones, but it's listing that the roms for them are missing/incorrect. In the case of goldnaxe, it's showing that I'm missing the roms for its clones but I don't even have or use them. It doesn't remove them from the list until I download the clone roms and add them to the parent rom zip.
No.07286 Fujix Administrator Mar 3, 2011, 04:49	This started from u3. And I confirmed it in some games. Even in the same driver, some games have "bad" message and others don't, for example: aliensyn, fpoint, eswat, shinobi, sdi : "Missing" message wb, goldnaxe, altbeast : "Bad" message We don't find out what is common among "BAD" sets yet.
No.07287 Tafoid Administrator Mar 3, 2011, 05:06	It's not present in r11570 and is showing up in r11587. Strongly suspect issue with r11587 which involves hash collection rewrites.
No.07288 belegdol Tester Mar 3, 2011, 07:32	I'm glad that you managed to reproduce this. Keep in mind though that the issue with gtfrk3ma was present before u3. Out of the files involved, I only have sys573.zip, which contains 700a01.22g and digital-id.bin in my rompath.
No.07289 Fujix Administrator Mar 3, 2011, 09:02	From my quick test, the first version -verifyroms reports BAD for gtfrk3ma is 0.123. In 0.122, it returns just "romset "gtfrk3ma" not found!", it could be a different problem.
No.07359 belegdol Tester Apr 3, 2011, 08:34	in u4, goldnaxe problem is gone but gtfrk3ma/gtfrk10ma one remains.