04096: sjryuko: Most inputs do not work

ID	Category [?]	Severity [?]	Reproducibility	Date Submitted	Last Update
04096	DIP/Input	Major	Always	Oct 24, 2010, 19:10	Nov 7, 2010, 15:45

Tester	M.A.S.H.	View Status	Public	Platform	MAME (Self-compiled)
Assigned To	Kale	Resolution	Fixed	OS	Windows XP (32-bit)
Status [?]	Resolved			Driver	sega/segas16b.cpp
Version	0.140	Fixed in Version	0.140u1	Build	Normal
		Fixed in Git Commit		Github Pull Request #

Summary	04096: sjryuko: Most inputs do not work
Description	Input (Mahjong A/B) doesn't work on select screen (see snapshot). In MAME 0.136u3 the I/O handler was changed. If you changed it back to 0.136u2, the Mahjong A/B input work again. Source (drivers\segas16b.c) line 1771: Changed static WRITE16_HANDLER( sjryuko_custom_io_w ) back to: static WRITE16_HANDLER( sjryuko_custom_io_w ) { static UINT8 mj_last_val; segas1x_state *state = space->machine->driver_data<segas1x_state>(); switch (offset & (0x3000/2)) { case 0x0000/2: if (((mj_last_val ^ data) & 4) && (data & 4)) state->mj_input_num = (state->mj_input_num + 1) % 6; break; } standard_io_w(space, offset, data, mem_mask); }
Steps To Reproduce
Additional Information
Github Commit

Flags
Regression Version	0.136u3
Affected Sets / Systems	sjryuko

Attached Files	sjryuko.png (11,917 bytes) Oct 24, 2010, 19:10

No.06798 Haze Senior Tester Oct 24, 2010, 19:31 edited on: Oct 24, 2010, 19:37	static variables in functions create multi-session / reset / save state issues, the code you've posted is not an appropriate fix. (nor for that matter does it make any sense, mj_last_val is never assigned, just used)
No.06799 Tafoid Administrator Oct 24, 2010, 19:45	The test mode shows that most of the buttons are not being detected. In fact, only EFGH are even detected. Upgrading to MAJOR as this renders the game as completely unplayable.