04061: quasar: Missing sound effects

ID	Category [?]	Severity [?]	Reproducibility	Date Submitted	Last Update
04061	Sound	Minor	Always	Sep 24, 2010, 07:20	Sep 17, 2015, 18:28

Tester	M.A.S.H.	View Status	Public	Platform	MAME (Self-compiled)
Assigned To		Resolution	Open	OS
Status [?]	Confirmed			Driver	cvs/quasar.cpp
Version	0.139u3	Fixed in Version		Build	Normal
		Fixed in Git Commit		Github Pull Request #

Summary	04061: quasar: Missing sound effects
Description	The boot/start sound and the alien shoot sound is missing in Quasar since MAME 0.127u1. Source: drivers\quasar.c was changed and i think it has something todo with a missing soundlatch clear (see snapshot).
Steps To Reproduce	Start MAME 0.127 with Quasar and you can hear the start sound. Then compare it with MAME 0.127u1.
Additional Information
Github Commit

Flags
Regression Version	0.127u1
Affected Sets / Systems	quasar

Attached Files	MAME0127-0127u1-Quasar-Driver.png (29,160 bytes) Sep 24, 2010, 07:20

No.12027 Osso Moderator Sep 15, 2015, 10:39	Is the shoot sound still missing? It seems to be there for me, if there isn't an explosion sound already playing.
No.12029 M.A.S.H. Senior Tester Sep 15, 2015, 23:50	The shoot sounds from the aliens are missing and not the player shoot sound. My report was not correct. I fixed it!
No.12031 Osso Moderator Sep 16, 2015, 11:09	Ah I misunderstood the report, thanks for clarifying! Adding "soundlatch_byte_w(space, 0, 0);" in quasar_sh_command_r does restore the missing sound of the enemy shots, but Aaron must have removed it for a reason.
No.12035 Stiletto Developer Sep 17, 2015, 04:48	Footage from US Billiards (Zaccaria) set:
No.12036 Mamesick Senior Tester Sep 17, 2015, 18:28 edited on: Sep 17, 2015, 18:36	IIRC there's a comment in the driver by Aaron where it says that he's following probably wrong schematics.... So maybe that soundlatch write should be there and was wrongly removed. EDIT: here it is: // not necessarily like this, but it seems to work better than direct mapping // (although schematics has it as direct - but then the schematics are wrong elsewhere to!) Also this note at the top of the driver: - Sound (missing invader effect - still not sure all noise in correct places)