03941: darkseal2: Cutscenes suffer from glitched-up voice samples

ID	Category [?]	Severity [?]	Reproducibility	Date Submitted	Last Update
03941	Sound	Minor	Always	Jul 14, 2010, 01:18	Jun 22, 2015, 16:42

Tester	Samurai Fox	View Status	Public	Platform	MAMEUI
Assigned To		Resolution	Reopened	OS
Status [?]	Confirmed			Driver	dataeast/rohga.cpp
Version	0.138u3	Fixed in Version		Build	64-bit
		Fixed in Git Commit		Github Pull Request #

Summary	03941: darkseal2: Cutscenes suffer from glitched-up voice samples
Description	This occurs exclusively in the Japanese version of Wizard Fire (which is called Dark Seal 2 in Japan). As soon as the first cut-scene starts, right after selecting your character, wrong voice samples will be playing. I'm not sure if Dark Seal 2 still used the English voice overs from the "US" and "Overseas" versions, but in it's current state it seems to be trying to and it's obviously glitched.
Steps To Reproduce	Start the game and select your character, and watch the first cut-scene before playing the game.
Additional Information	This was tested from the latest MAMEUI build, but this was first tested on the latest official MAME build from http://mamedev.org. Both versions have this problem, it seems.
Github Commit

Flags
Regression Version	Since Added
Affected Sets / Systems	darkseal2

Attached Files

No.06370 Tafoid Administrator Jul 14, 2010, 14:49	Tested back to when added and it's always been the same way. I'll label it confirmed, but possible, pending some original pcb verification and possible redump of sound/sample roms.
No.09689 Haze Senior Tester Jul 30, 2013, 12:34	looking at this while working on the Data East protections looks like the sample roms should be banked and the bank change was never hooked up, I'll look into it.
No.09837 Phil Bennett Developer Sep 25, 2013, 14:45	The voiceovers should be Japanese: The equivalent of sound ROM 'MAS10' (and possibly MAS11) needs to be dumped for this set as the US/World ROM contains only English voiceovers.
No.09838 AWJ Developer Sep 25, 2013, 15:50	Phil, are you sure there aren't Japanese voice samples in another bank of the ROM? The oki ROMs are 0x80000 bytes, meaning there needs to be some kind of banking for the chip to see the entire ROM--an okim6295 can only address 0x20000 bytes by itself.
No.09840 Phil Bennett Developer Sep 25, 2013, 19:23	Yes. I've listened to both sample ROMs in their entirety and neither contain the Japanese voiceovers.
No.11739 M.A.S.H. Senior Tester Jun 10, 2015, 17:25	Fixed by Porchy and The Dumping Union in r38586.
No.11741 system11 Senior Tester Jun 10, 2015, 18:09 edited on: Jun 12, 2015, 19:43	Note that just adding the larger ROM doesn't fix it. The top half contains English voices and the bottom half Japanese. This 'fixes' the Japanese set because the bank selection isn't working properly (actually from doing some basic tracing on the PCB, seems to be CPU control of A19 on MAS10), but breaks the English. Just checked on the PCB and on the Japanese board indeed A19 is held low by logic (traced back as far as a LS74), it doesn't change once the game has booted so the Japanese set is essentially being hardwired to use the lower half and the World set is hardwired to the upper half of MAS10, but this is being done in code somewhere. Note updating this comment - MAS11 is correct, turns out to actually be a 4M chip.
No.11742 system11 Senior Tester Jun 10, 2015, 20:27	See note - still issues here since fix has broken another region.
No.11753 Haze Senior Tester Jun 11, 2015, 10:38 edited on: Jun 11, 2015, 10:38	can you trace back any further on the PCB? i'd like to know roughly where I'm looking to control this. The bankswitch writes on the usual bankswitch ports are the same on both games, so there the upper address line bit must come from elsewhere, maybe on the maincpu side? (unless there's a jumper hardcoding it on the PCB?) however I don't really see any different writes between the games at the moment. I guess I could simply hardcode the sets to use upper/lower, but if the hardware can select, we should find the select bits.
No.11757 system11 Senior Tester Jun 12, 2015, 17:35	Definitely not a jumper because you can successfully switch it by just changing the code ROM.
No.11784 Haze Senior Tester Jun 22, 2015, 16:42	This is hacked around for 0.163, swapping the halves for Wizdfire and leaving them unswapped for Darlkseal 2. A proper fix is needed (finding how the bankswitch hooks up) but for now the sound should be correct.