03789: ambush: Incorrect colors

ID	Category [?]	Severity [?]	Reproducibility	Date Submitted	Last Update
03789	Graphics	Minor	Always	Mar 20, 2010, 19:55	Feb 20, 2011, 20:52

Tester	Smitdogg	View Status	Public	Platform	MAMEUI
Assigned To	hap	Resolution	Fixed	OS	Windows Vista/7 (64-bit)
Status [?]	Resolved			Driver	tecfri/ambush.cpp
Version	0.137	Fixed in Version	0.141u3	Build	64-bit
		Fixed in Git Commit		Github Pull Request #

Summary	03789: ambush: Incorrect colors
Description	I attached photos from a pcb (auction). The background color of the speedometer, altimeter, etc. are the wrong color in MAME. There may also be other small differences. I can't tell if the blue background changed in the last 2 pictures or if a camera angle caused the differences.
Steps To Reproduce
Additional Information	Affected sets updated in 0.142u2.
Github Commit

Flags
Regression Version	0.36RC2
Affected Sets / Systems	ambush

Attached Files	0.jpg (63,125 bytes) Mar 20, 2010, 19:55
	1.jpg (65,589 bytes) Mar 20, 2010, 19:55
	2.jpg (60,425 bytes) Mar 20, 2010, 19:56
	Ambush-036RC1.png (2,610 bytes) Mar 21, 2010, 02:36
	Ambush-0137.png (3,622 bytes) Mar 21, 2010, 02:36
	Ambush-036RC1-SNAP02.png (2,627 bytes) Mar 21, 2010, 02:42

No.05903 M.A.S.H. Senior Tester Mar 21, 2010, 02:38 edited on: Mar 21, 2010, 03:01	Found the regression version (MAME 0.36RC2) and added a MAME 0.36RC1 and 0.137 Ambush snapshot. The colors in 0.36RC1 match the ones in the PCB! The radar display on the upper right corner disappeared in MAME 0.36b10.
No.05905 Haze Senior Tester Mar 21, 2010, 13:24	if you ignore the transpen the boxes have the right colour (but flash a lot, I don't know if they're meant to) drawgfx_opaque(bitmap,cliprect,machine->gfx[0], code, (col & 0x0f) \| ((state->colorbank & 0x03) << 4), flip_screen_get(machine), flip_screen_get(machine), 8 sx, (8 * sy + scroll) & 0xff); however, that causes part of the sky to also be solid, so you can't see the enemies. basically the transparency handling in the driver appears to be incorrect.

No.05903

M.A.S.H.

Senior Tester

Mar 21, 2010, 02:38

edited on: Mar 21, 2010, 03:01

Found the regression version (MAME 0.36RC2) and added
a MAME 0.36RC1 and 0.137 Ambush snapshot.
The colors in 0.36RC1 match the ones in the PCB!
The radar display on the upper right corner disappeared in MAME 0.36b10.

No.05905

Haze

Senior Tester

Mar 21, 2010, 13:24

if you ignore the transpen the boxes have the right colour (but flash a lot, I don't know if they're meant to)

drawgfx_opaque(bitmap,cliprect,machine->gfx[0],
code,
(col & 0x0f) | ((*state->colorbank & 0x03) << 4),
flip_screen_get(machine), flip_screen_get(machine),
8 * sx, (8 * sy + scroll) & 0xff);

however, that causes part of the sky to also be solid, so you can't see the enemies.

basically the transparency handling in the driver appears to be incorrect.