03714: captcomm + clones: Crash if active -cheat trigger is used

ID	Category [?]	Severity [?]	Reproducibility	Date Submitted	Last Update
03714	Cheat System	Critical (emulator)	Always	Feb 5, 2010, 22:12	Feb 6, 2010, 00:13

Tester	fallicanet	View Status	Public	Platform	MAMEUI
Assigned To		Resolution	Invalid report	OS	Windows XP (32-bit)
Status [?]	Closed			Driver	capcom/cps1.cpp
Version	0.136u2	Fixed in Version		Build	Normal
		Fixed in Git Commit		Github Pull Request #

Summary	03714: captcomm + clones: Crash if active -cheat trigger is used
Description	MAME crash if -cheat (command line) or active "enable game cheats" (mameui) MAMEUI32 0.136u2 + Pugsy cheat 0.136
Steps To Reproduce
Additional Information	captcomm.xml(320): error parsing XML (mismatched tag) Program received signal SIGSEGV, Segmentation fault. 0x0183181a in xml_file_free (node=0x0) at src/lib/util/xmlfile.c:277 277 if (node->name != NULL) Current language: auto The current source language is "auto; currently c++". (gdb) bt #0 0x0183181a in xml_file_free (node=0x0) at src/lib/util/xmlfile.c:277 #1 0x01009cc0 in cheat_list_load (machine=0x254d08, filename=0xfc70080 "captcomm") at src/emu/cheat.c:1101 #2 0x01008254 in cheat_reload (machine=0x254d08) at src/emu/cheat.c:423 #3 0x010080eb in cheat_init (machine=0x254d08) at src/emu/cheat.c:388 #4 0x00d88439 in init_machine (machine=0x254d08) at src/emu/mame.c:1452 #5 0x00d84d26 in mame_execute (options=0xfa84940) at src/emu/mame.c:295 #6 0x00fef639 in cli_execute (argc=4, argv=0xfa847a0, osd_options=0x29e30c0) at src/emu/clifront.c:176 #7 0x00cc226c in utf8_main (argc=4, argv=0xfa847a0) at src/osd/windows/winmain.c:318 #8 0x0187092e in wmain (argc=4, argv=0xfa84450) at src/osd/windows/main.c:82 #9 0x004013d1 in __tmainCRTStartup () at ../mingw-w64-crt/crt/crtexe.c:268 #10 0x7c5989d5 in ProcessIdToSessionId () from C:\WINNT\system32\KERNEL32.DLL #11 0x00000000 in ?? ()
Github Commit

Flags
Regression Version
Affected Sets / Systems	captcomm + clones

Attached Files	fixed_captcomm_xmls.zip (4,764 bytes) Feb 6, 2010, 00:13

No.05634 Tafoid Administrator Feb 5, 2010, 22:41 edited on: Feb 5, 2010, 23:02	This is likely a cheat.xml related issue rather than MAME. Confirming it in the mean time. This appears to be due to a missing </parameter> tag and a malformed cheat for region. It still shouldn't crash MAME, I don't think.
No.05635 etabeta Developer Feb 5, 2010, 23:59 edited on: Feb 6, 2010, 00:01	it does not happen without cheats -> it is not a MAME problem -> it has to be reported to Pugsy and not here. closing ETA (to clarify): if it is really due to the missing tag, then the xml is malformed and not a MAME issue
No.05636 Tafoid Administrator Feb 6, 2010, 00:06	That's fine. My only concern, bad tag or not, it was crashing MAME. That's the only reason I accepted it in the first place.
No.05637 Pugsy Developer Feb 6, 2010, 00:13	Me bad, must add a test to my checkers for that. I've uploaded the fixed xmls for captcomm + clones.