03424: chihiro, triforce: Access Violation before typing OK

ID	Category [?]	Severity [?]	Reproducibility	Date Submitted	Last Update
03424	Crash/Freeze	Critical (emulator)	Always	Sep 4, 2009, 03:21	Oct 27, 2009, 21:15

Tester	Tafoid	View Status	Public	Platform	MAME (Self-compiled)
Assigned To	etabeta	Resolution	Fixed	OS	Windows 2000
Status [?]	Resolved			Driver
Version	0.133u4	Fixed in Version	0.135	Build	Normal
		Fixed in Git Commit		Github Pull Request #

Summary	03424: chihiro, triforce: Access Violation before typing OK
Description	Both bioses when run crash before OK can be typed or any information screen can be seen. Backtrace: Program received signal SIGSEGV, Segmentation fault. 0x78010aa8 in memcpy () from C:\WINNT\system32\msvcrt.dll (gdb) bt #0 0x78010aa8 in memcpy () from C:\WINNT\system32\msvcrt.dll #1 0x0087ddc5 in load_rom_gdrom (machine=0xb5d1ef0, v=0x1c781fb8) at src/mame/machine/naomibd.c:725 Backtrace stopped: frame did not save the PC (gdb) bt full #0 0x78010aa8 in memcpy () from C:\WINNT\system32\msvcrt.dll No symbol table info available. #1 0x0087ddc5 in load_rom_gdrom (machine=0xb5d1ef0, v=0x1c781fb8) at src/mame/machine/naomibd.c:725 result = 3124865706 gdromfile = (cdrom_file ) 0x3b363e buffer = '\0' <repeats 32 times>, "\001\001\001\001\001\001\001\001+)\"\ 000d~vwP\026°w\000\000\000\000¦)\"\000-\221W\|\000\000\000\000\000\000\000\000_)\ "\000d~vwP\026°w 8)\"\000-\221W\|\000\000#\000h\000\024@0\000\000\000(\203R\02 30\000\000\000°\202R\023_)\"\000\2140(w\b\000\000\000°\202R\0230\000\000\000¦)\" \000\000\000\000\000a \"\000`!\\\|(\203R\023 n)\"\000-¬t\v@\000\000\000+ F\v\2 32\000@¬\000@#$÷\"\000\001\000\000\000=n$\000a°$\000\003\000\000\000\000\000\00 0\b\000\000\000\000\004", '\0' <repeats 11 times>... ptr = (UINT8 *) 0x0 start = 464330504 size = 2293128 sectors = 11266339 dir = 464330496 pos = 34270166 len = 131072 a = 191176681 name = '\0' <repeats 127 times> key = 0
Steps To Reproduce
Additional Information
Github Commit

Flags
Regression Version	0.130u1
Affected Sets / Systems	chihiro, triforce

Attached Files

No.05041 sz72 Tester Oct 20, 2009, 14:51	Sice bioses have no gdrom file and no security pic data, the relative regions are not present and the function load_rom_gdrom() (that reads the 'rom file' from the chd) should not do anything. You can add the foillowing in the load_rom_gdrom() function before the first memset() call if ((v->picdata == NULL) \|\| (v->gdromchd == NULL)) return; // maybe output a message too
No.05073 etabeta Developer Oct 27, 2009, 21:15 edited on: Oct 27, 2009, 21:15	it's even better not to call at all the load_rom_gdrom if any of picdata, gdromchd or memory is NULL ;)