 No.04790
couriersud Developer
Aug 9, 2009, 23:21
|
Flamethrowers loaded -:) Whether or not it is unsafe surely depends on the context. If you are talking about fluid dynamic models, a == b on e.g. velocity components will never trigger. MAME is different. In a lot of cases, there is a comparison against 0.0 . It is assumed and required that the 0.0 is not the result of a computation but directly assigned: a = 0.0 Later If a == 0.0 or if (a!=0.0) This of course relies on the compiler to convert 0, 0.0, 0.0000 to the same binary representation. Within the discrete sound core there must be tons of these warnings. it has tons of double a; if (a) This is on purpose and works and is *fast*. Whether it is 101 compliant code style, well. |
|---|---|
|
No.04807
R. Belmont Developer
Aug 13, 2009, 19:57
|
Yeah. I wouldn't look amiss on someone auditing these cases for potential actual errors, but just blanket-flagging them with -Wfloat-equal is a sure way to annoy a lot of devs. |
 No.04808
hap Developer
Aug 13, 2009, 21:41
|
hmm, yes I agree |