00313: speedatk: When you activate the flip screen the graphics are moved over to one side.

ID	Category [?]	Severity [?]	Reproducibility	Date Submitted	Last Update
00313	Flip Screen/Cocktail	Minor	Always	Jan 28, 2008, 05:47	Jun 10, 2012, 03:26

Tester	-Misc Reporters-	View Status	Public	Platform
Assigned To	Kale	Resolution	Fixed	OS
Status [?]	Resolved			Driver	seta/speedatk.cpp
Version	0.120	Fixed in Version	0.141u3	Build
		Fixed in Git Commit		Github Pull Request #

Summary	00313: speedatk: When you activate the flip screen the graphics are moved over to one side.
Description	When you activate the flip screen the graphics are moved over to one side. Robbbert says : It's easy to fix. src\mame\video\speedatk.c Go right to the bottom, you see a section VIDEO_START ( speedatk ) Add an extra line to it: tilemap_scroll_dx(bg_tilemap, 0, 48); There is another bug, on the second screen of the attract sequence, the logo is missing. This is easily fixed by modifying static TILE_GET_INFO ( get_tile_info ) section. Where it says color += 2; change it to read: if (colorram[tile_index] < 254) color += 2;
Steps To Reproduce
Additional Information
Github Commit

Flags
Regression Version
Affected Sets / Systems	speedatk

Attached Files

No.01757 etabeta Developer Jul 23, 2008, 15:29	both bugs mentioned here are still in MAME. has the reported fix ever been submitted?
No.01760 Tafoid Administrator Jul 23, 2008, 17:53	I would have figured a dev would have stepped in and confirmed/added this fix by now - provided it wasn't a hack. I don't know enough about it to make that judgment. There are a few "easy to fix" bugs that can be fixed but in a hacky way (not following certain coding guidelines). MAMEUIFX has some of these in it's build fixing many Mantis bugs..
No.01763 Robbbert Senior Tester Jul 24, 2008, 07:07	This was so long ago I had entirely forgotten about it. I'll leave it to others to decide if this is of the required standard.
No.01764 Haze Senior Tester Jul 24, 2008, 07:18	well the 2nd fix is clearly a hack.
No.02995 Kale Developer Nov 4, 2008, 17:02	Speed Attack has a hack on the video emulation,it'll require some better coding than one line fix...
No.07183 Kale Developer Feb 10, 2011, 03:35	Fixed. Explaination: Speed Attack uses a weird resolution (272 x 224) that doesn't quite fit into a 0x400 videoram space, so, in order to draw correctly under the flip screen state they use the mc6845 base register for compensate for the offsetting. 272 / 8 = 34 (max width) 224 / 8 = 28 (max height) 34 * 28 = 952 = 0x3b8 used videoram bytes 0x400 - 0x3b8 = 0x0048 ... and that's the value setted inside the mc6845 registers [0x0c] and [0x0d]. Needless to say, I've fully rewrote the video emulation from scratch just to take this into account ...