03118: All Sets in bishi.c: Labels for input buttons are misleading

ID	Category [?]	Severity [?]	Reproducibility	Date Submitted	Last Update
03118	DIP/Input	Feature	N/A	Apr 22, 2009, 23:43	Apr 23, 2009, 03:25

Tester	nightsoil	View Status	Public	Platform	MAMEUI
Assigned To		Resolution	No change required	OS	Windows XP/Vista 32-bit
Status [?]	Closed			Driver	konami/bishi.cpp
Version	0.130u2	Fixed in Version		Build	Normal
		Fixed in Git Commit		Github Pull Request #

Summary	03118: All Sets in bishi.c: Labels for input buttons are misleading
Description	The game sbishi uses 3 input buttons. The labels "button 1" and "button 3" are misleading if one reads left to right. MAME's "button 3" should be "Red (left) button" MAME's "button 2" should be "Green (middle) button" MAME's "button 1" should be "Blue (right) button" I mention the colors because they are relevant in a number of the minigames.
Steps To Reproduce
Additional Information
Github Commit

Flags
Regression Version
Affected Sets / Systems	All Sets in bishi.c

Attached Files

No.04243 Tafoid Administrator Apr 23, 2009, 01:28	They appear to be button 1, 2 and 3 as listed in bit order in the driver. I can acknowledge they are not default mapped in a manner that would be logical for the game (left to right) .. it's actually (right to left). As far as programming goes, bit order starts on the right and works left as it increases. In this respect, MAME is correct.
No.04244 Fujix Administrator Apr 23, 2009, 03:23	nightsoil, I know your feelings, but if we forced this rule to other games, for example in Gradius, the button 1 should have to be "Power-UP", button 2 were "Shot" and button 3 were "Missile". I remember there used to be a similar suggestion and plan, but it was not implemented finally. I think we should leave it to the driver author's discretion, except for simple mistakes.