02060: spinlbrk, spinlbrku, spinlbrkj: Priorities wrong

ID	Category [?]	Severity [?]	Reproducibility	Date Submitted	Last Update
02060	Graphics	Minor	Always	Jul 31, 2008, 18:52	Jul 4, 2019, 06:47

Tester	Kold666	View Status	Public	Platform	MAME (Official Binary)
Assigned To	Osso	Resolution	Fixed	OS
Status [?]	Resolved			Driver	vsystem/aerofgt.cpp
Version	0.126u3	Fixed in Version	0.212	Build
		Fixed in Git Commit		Github Pull Request #

Summary	02060: spinlbrk, spinlbrku, spinlbrkj: Priorities wrong
Description	Wrong sprites priorities with background objects
Steps To Reproduce
Additional Information
Github Commit

Flags
Regression Version	0.204
Affected Sets / Systems	spinlbrk, spinlbrku, spinlbrkj

Attached Files	0000.png (23,084 bytes) Jul 31, 2008, 18:55
	0001.png (27,455 bytes) Jul 6, 2015, 21:13 Uploaded by izius
	spinlbrk.zip (22,439 bytes) Jul 7, 2015, 05:33 Uploaded by izius Save states taken in level 2 and 6
	spinlbrk0003.png (11,412 bytes) Jun 29, 2019, 22:17 Uploaded by haynor666
	0002.png (18,955 bytes) Jul 1, 2019, 17:52 Uploaded by izius

No.11659 izius Tester May 7, 2015, 20:46 edited on: Jul 7, 2015, 05:31	This bug should be reopened, as it happens again in 0.163. Also, it can happen in other stages if an enemy comes in the foreground - tipically with a close range attack - and there are other sprites in the background. I'm uploading a screenshot of level 6, where the ninjas can jump forward and frequently cause the problem. Later edit: uploaded also save states. Regression in 0.147u3.
No.16599 haynor666 Tester Jun 29, 2019, 22:17 edited on: Jun 29, 2019, 22:18	It happens still in version 210. Priorities are wrong even in story presentation.
No.16601 izius Tester Jul 1, 2019, 17:51	That's a new issue. The one I noted in 2015 was actually fixed in 0.164, along with 05981. Just did a bit of testing, this one began in 0.204 and behaves differently from the past; for example, level 1 enemy soldiers now pass behind trees and electric poles, which are in the far background.
No.16602 Mamesick Senior Tester Jul 2, 2019, 04:47 edited on: Jul 2, 2019, 04:49	Regression is this commit: https://github.com/mamedev/mame/commit/ebbd25c8665321f51ba35d573dbc3fc49dbf867f#diff-60a60522aafdd7b4f6da480e005c24d4 and precisely the fix is at line 1837 of mame/drivers/aerofgt.cpp m_spr_old[0]->set_pritype(1); should be m_spr_old[1]->set_pritype(1);
No.16610 Osso Moderator Jul 2, 2019, 13:42 edited on: Jul 2, 2019, 13:43	Thanks for spotting my dumb error! Updated: https://github.com/mamedev/mame/commit/562de4d2f3ffca939fc5a537384d193c0b39c868