01665: zigzag, zigzag2: Animation of hose does not show properly when attempting to pump enemies.

ID	Category [?]	Severity [?]	Reproducibility	Date Submitted	Last Update
01665	Graphics	Minor	Always	Apr 3, 2008, 17:09	Mar 21, 2011, 23:51

Tester	haynor666	View Status	Public	Platform	MAME (Self-compiled)
Assigned To	hap	Resolution	Fixed	OS
Status [?]	Resolved			Driver	galaxian/galaxian.cpp
Version	0.124u1	Fixed in Version	0.141u4	Build	C2D
		Fixed in Git Commit		Github Pull Request #

Summary	01665: zigzag, zigzag2: Animation of hose does not show properly when attempting to pump enemies.
Description	The screen shows an odd corruption in places when you attempt to pump an enemy and does not show it's proper animation.
Steps To Reproduce	Run game and try to eliminate enemies from distance.
Additional Information
Github Commit

Flags
Regression Version	0.124u1
Affected Sets / Systems	zigzag, zigzag2

Attached Files	0003.png (6,381 bytes) Apr 3, 2008, 17:09
Attached Files	zigzag.diff (22,443 bytes) Mar 10, 2010, 23:35 [Show Content]

No.00523 Tafoid Administrator Apr 3, 2008, 17:54	Rewrote items to better describe the bug. Confirmed.
No.03221 Robbbert Senior Tester Dec 4, 2008, 10:30	Probably related - you cannot see the dragon's fire.
No.05848 M.A.S.H. Senior Tester Mar 10, 2010, 23:35	Zig Zag (LAX 1982) was in MAME 0.124 in the old galaxian.c driver, then in 0.124u1 the driver was splitted into galaxian.c, galdrvr.c and galaxold.c. Zig Zag now uses a new memory map. Since this version it has graphical glitches and animation of hose and dragon fire are missing. I found out that Zig Zag need the old galaxold_attributesram_w, that was not in the galaxian/galdrvr.c. I completely moved the game to the galaxold.c driver and everything works fine again! Use attached DIFF file for testing.
No.05849 Haze Senior Tester Mar 10, 2010, 23:42	moving things to an old deprecated driver isn't a fix. please attempt to understand..... using old code IS NOT progress, and IS NOT a fix. fix the new driver properly! This isn't the first time you've done this. I really wonder if you're learning anything.
No.05850 M.A.S.H. Senior Tester Mar 10, 2010, 23:54	Then how could we add the needed galaxold_attributesram_w to galdrvr.c. I didn't find a way. It always craches MAME. >This isn't the first time you've done this. When was the last time? Please tell me!
No.05852 Haze Senior Tester Mar 11, 2010, 01:15 edited on: Mar 11, 2010, 01:22	> Then how could we add the needed galaxold_attributesram_w to galdrvr.c. I didn't find a way. It always craches MAME. There is nothing complex about the driver.. If you can't understand basic coding beyond 'copy old driver, delete new code' then I can't help you. Again using the old galaxold_attributesram_w by copying it to the new driver is not a fix. The game runs on standard galaxian hardware with some slight modifications, it shouldn't need an entirely different set of code. >>This isn't the first time you've done this. >When was the last time? Please tell me! even in the soccer bug right below this one you're proposing to revert the code to the previous values.. it's common with your reports!